fix elsint problem and add container in html change entry path to pub… #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lic in webpack-config #6
abdhalees
suggested changes
Feb 5, 2018
| import { render } from 'react-dom'; | ||
| import App from './components/App'; | ||
|
|
||
| render(<App />, document.getElementById('container')); |
Contributor
There was a problem hiding this comment.
this won't work, you need to import react-dom and call render from it like this:
import ReactDOM from 'react-dom';
ReactDOM.render(
<App />,
document.getElementById('container')
);and if you are going to use redux you will need to import react-redux here and provide the store like this:
import { Provider } from 'react-redux';
import store from './store';
ReactDOM.render(
<Provider store={store}>
<App />
</Provider>,
document.getElementById('container')
);| "clean": "rimraf build", | ||
| "prod:build": "clean && webpack -p" | ||
| "clean": "rimraf public/bundle.js", | ||
| "prod:build": "npm run clean && webpack -p" |
Contributor
There was a problem hiding this comment.
add start and build scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lic in webpack-config
#6